docker-mender-convert: fix mktemp invocation for macOS/*BSD #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TheYoctoJester, Let me know if you want to start the integration pipeline by mentioning me and the command "start pipeline". my commands and optionsYou can trigger a pipeline on multiple prs with:
You can cherry pick to a given branch or branches with:
|
lluiscampos
approved these changes
Feb 14, 2022
|
@TheYoctoJester As our polite CI is reminding you, the commit is missing the |
Changelog: fix compatibility of docker-mender-convert with macOS/*BSD The macOS/*BSD versions of mktemp do not support the -p flag for passing in a path prefix. Fixing this by making $(pwd) part of the template (-t). Based on a suggestion at [1]. [1]: https://hub.mender.io/t/bug-convert-a-raw-disk-image-in-macos-fails-mktemp-illegal-option-p/4428/3?u=theyoctojester Signed-off-by: Josef Holzmayr <josef.holzmayr@northern.tech>
TheYoctoJester
force-pushed
the
macOS-fixes
branch
from
19089aa
to
c67b5ea
Compare
|
@lluiscampos done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: fix compatibility of docker-mender-convert with macOS/*BSD