This repository has been archived by the owner on Aug 15, 2023. It is now read-only.
Unify the handling of the data dir option #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also note that it is now applied, prior to setting up the logger Changelog: None Signed-off-by: Ole Petter <ole.orhagen@northern.tech>
oleorhagen
force-pushed
the
respectdata
branch
from
edacd39
to
22ef581
Compare
|
Merging due to customer requirement |
| @@ -226,6 +219,9 @@ def main(): | |||
| if args.version: | |||
| run_version(args) | |||
| return | |||
| if args.data: | |||
| log.info(f"Data store set to: {args.data}") | |||
| settings.PATHS = settings.Path(data_store=args.data) | |||
There was a problem hiding this comment.
there is one in the module with comment on being singleton. is that on purpose?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also note that it is now applied, prior to setting up the logger
Changelog: None
Signed-off-by: Ole Petter ole.orhagen@northern.tech