Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA-286: add websocket support to the stress test client #48

Merged
merged 2 commits into from
Jun 25, 2021

Conversation

tranchitella
Copy link
Contributor

QA-286: add websocket support to the stress test client

Add a new option, --websocket, which enables the websocket connection
emulating mender-connect running on a stress-test fake device. The
websocket connection manages ping/pong control messages, and logs all
the messages received from the backend. The stress-test fake device
doesn't implement application-level protocols (e.g. remote terminal,
file transfer, port-forwarding) and will reject all sessions with the
appropriate error messages.

Changelog: title

Signed-off-by: Fabio Tranchitella fabio.tranchitella@northern.tech

Changelog: none

Signed-off-by: Fabio Tranchitella <fabio.tranchitella@northern.tech>
client/client.go Outdated Show resolved Hide resolved
client/client.go Outdated Show resolved Hide resolved
Add a new option, `--websocket`, which enables the websocket connection
emulating mender-connect running on a stress-test fake device. The
websocket connection manages ping/pong control messages, and logs all
the messages received from the backend. The stress-test fake device
doesn't implement application-level protocols (e.g. remote terminal,
file transfer, port-forwarding) and will reject all sessions with the
appropriate error messages.

Changelog: title

Signed-off-by: Fabio Tranchitella <fabio.tranchitella@northern.tech>
Copy link
Contributor

@lluiscampos lluiscampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we need the websocket protocol experts eyes on it.

@tranchitella
Copy link
Contributor Author

@alfrunes @merlin-northern waiting for your review :)

Copy link
Contributor

@alfrunes alfrunes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

websocket/connection.go Show resolved Hide resolved
@tranchitella tranchitella merged commit 36bd6f2 into mendersoftware:master Jun 25, 2021
@tranchitella tranchitella deleted the qa-286 branch June 25, 2021 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants