Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fallback to PEM_write_bio_PrivateKey if _traditional fails #35

Merged
merged 1 commit into from
Nov 19, 2020
Merged

Fallback to PEM_write_bio_PrivateKey if _traditional fails #35

merged 1 commit into from
Nov 19, 2020

Conversation

merlin-northern
Copy link

ChangeLog:none
Signed-off-by: Peter Grzybowski peter@northern.tech

@merlin-northern
Fallback to PEM_write_bio_PrivateKey if _traditional fails
7ffc821 
ChangeLog:none
Signed-off-by: Peter Grzybowski <peter@northern.tech>
@merlin-northern
Copy link
Author

related PR with some explanations: #34
new development is: most of the keys have the callbacks (x->ameth->old_priv_encode, e.g.: old_ec_priv_encode) required by PEM_write_bio_PrivateKey_traditional defined , ed25519 is not one of them.

@merlin-northern merlin-northern mentioned this pull request Nov 19, 2020
Closed
lluiscampos
lluiscampos approved these changes Nov 19, 2020
View reviewed changes
Copy link

@lluiscampos lluiscampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! This should make both stable (openssl 1.1.1d) and testing (openssl 1.1.1h) happy 👍

@merlin-northern merlin-northern merged commit 8a04f62 into mendersoftware:master Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lluiscampos lluiscampos lluiscampos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@merlin-northern @lluiscampos