fix: Job String Processor, Job Processor and support for encoding of variables. #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@merlin-northern, Let me know if you want to start the integration pipeline by mentioning me and the command "start pipeline". my commands and optionsYou can trigger a pipeline on multiple prs with:
You can start a fast pipeline, disabling full integration tests with:
You can cherry pick to a given branch or branches with:
|
|
@mender-test-bot start pipeline sugar please |
|
Hello 😸 I created a pipeline for you here: Pipeline-633779599 Build Configuration Matrix
|
This was referenced Sep 7, 2022
Closed
merlin-northern
changed the title
alfrunes
approved these changes
Sep 8, 2022
part of the beauty of one of the previous versions was: by default we encode in the URIs :> so we would not have to do it. I was about to update only in one place in enterprise, since in here there are only ids, scopes and statuses -- all of which will never work with non-URI permitted characters. But I will do it, for clarity, and for documentation :) Edit: 8444ca8 |
|
@mender-test-bot start pipeline sugar pretty please honey |
|
Hello 😸 I created a pipeline for you here: Pipeline-634344874 Build Configuration Matrix
|
merlin-northern
force-pushed
the
men_5819_escape_query_params_processor_alf
branch
2 times, most recently
from
8537ce6
to
8444ca8
Compare
|
Can you please fix the commits?
|
merlin-northern
force-pushed
the
men_5819_escape_query_params_processor_alf
branch
from
8444ca8
to
41f8b79
Compare
alfrunes
approved these changes
Sep 8, 2022
…variables.
* refactors code around processors
* allows to specify ${encoding=url;workflow.input.identifier}
* sets explicit encoding to url for all input values passed in the URI
* the extension of regular expressions by Alf see workflows/pull/235,
workflows/pull/234 with further fixes
Changelog: Support for flags insize the ${workflow.input.identifier} via ${encoding=url;workflow.input.identifier}
Changelog: All workflows use encoding=url in the input variables passed in the URIs.
Ticket: MEN-5819
Signed-off-by: Peter Grzybowski <peter@northern.tech>
merlin-northern
force-pushed
the
men_5819_escape_query_params_processor_alf
branch
from
41f8b79
to
3787ecb
Compare
|
not running the pipeline again, there were only squashes and commit msgs fixes. |
merlin-northern
changed the title
|
Hello 😸 This PR contains changelog entries. Please, verify the need of backporting it to the following release branches: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.