-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Met Eireann weather provider #34
Conversation
FYI, this displayed a severe weather warning this morning -- "small craft warning for all coasts", although it looks like this is not due to happen until Wednesday: "Small Craft warning for all coasts of Ireland Valid: 09:00 Wednesday 30/03/2022 to 00:00 Friday 01/04/2022 Issued: 06:32 Monday 28/03/2022" So the alert support is working, albeit may need a little work to filter out distant events. For the record, this is what the RSS doc looks like:
|
Thanks will start looking at this soon. I'll try to push directly to your branch to resolve some conflicts (I just added weather.gov so there were bound to be some) |
I think I've fixed the conflicts there.... |
@jmason it was a real pleasure going through this PR. You took the time to follow the structure, comment patterns, debug logging, naming conventions, documentation, samples, and I appreciated your efforts here. 👍 I've also got a few question, I noticed in your branch, you've got a 3 color screen. I am curious to know how long does the screen refresh take? What are the '20 km' and '143 km' values in the bottom right? I also liked the 'today' and 'tomorrow' instead of today/tomorrow's date, it's a nice friendly idea, I will look to add this too. |
Cheers! :)
It's very slow -- 50-60 seconds or thereabouts to do a full screen refresh. As a result, I only update it once per hour, so that has a big impact on the pieces of data to display. For example, I don't include the minutes or seconds in the time display -- just the date and the hour. The 3-color output looks great though :)
Those are the battery charge levels for our 2 electric cars; they're scraped from my local HomeAssistant instance.
Cool, that'd be great :) I can provide diffs if that'd help? |
merge from upstream
This data is more useful, as it's easier to pick out county-specific alerts and ignore irrelevant warnings.
Met Eireann alerts
Nice thanks for those answers, I'm always curious to see how this project is used
It's fine, I've found it already, no worries! |
A new weather provider using Ireland's national weather service, Met Eireann. (also a tidier version of #33)
I think it should also achieve the license condition of supporting the alert API as well, which handily enough uses the same format as the Met Office one. I haven't seen what this looks like in reality yet though.... as there is no weather alert in progress right now :)