[WC-2474]: Handle keyboard nav for input elements in Gallery #1104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iobuhov
reviewed
Jun 6, 2024
packages/pluggableWidgets/gallery-web/src/components/ListItem.tsx
Outdated
Show resolved
Hide resolved
iobuhov
reviewed
Jun 6, 2024
packages/pluggableWidgets/gallery-web/src/components/ListItem.tsx
Outdated
Show resolved
Hide resolved
rahmanunver
force-pushed
the
fix/wc-2474_gallery_keyboard_propagation
branch
from
e327f64
to
65cf7cf
Compare
rahmanunver
force-pushed
the
fix/wc-2474_gallery_keyboard_propagation
branch
2 times, most recently
from
ed7ad3c
to
94ca1be
Compare
samuelreichert
previously approved these changes
Jun 21, 2024
leonardomendix
previously approved these changes
Jun 25, 2024
rahmanunver
force-pushed
the
fix/wc-2474_gallery_keyboard_propagation
branch
from
94ca1be
to
c099c7e
Compare
rahmanunver
dismissed stale reviews from leonardomendix and samuelreichert
via
9d02ae6
iobuhov
approved these changes
Jun 26, 2024
leonardomendix
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Bug fix (non-breaking change which fixes an issue)
Description
Added a new handler method to check if the element is an HTMLInputElement, if so stop the propagation.
What should be covered while testing?
Demo project link and #frontend thread:
https://mendix.slack.com/archives/CJZ85RLTA/p1714654971335249
Input elements inside Gallery widget should now be able to use arrow keys to move cursor when focused, but this means where are stopping event propagation for the input elements, which means keyboard navigation behavior for text inputs are going to change.