[Issue #23] Allow larger than 2GB files to be read. #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`read` and `write` return a signed int, meaning that they can only read up to 2 billion bytes (2GB) at a time. bsdiff and bspatch were expecting the entire file to be read (or written, respectively) in a single call to `read` or `write`, which is only possible if they are less than 2GB in size. There are also other times in which a single function call would be inadequate for IO, for instance in the case where a device is busy. The fix for this was to place the functions in a loop and continue as long as at least 1 byte was transferred (in or out). If an error, or 0 return value, comes back from the transfer, break out of the loop and return the total number of bytes that had been transferred up to that point. Updated the .gitignore file to ignore vim swap files, as well as the autoconf (generated) files and the executables.
gaetandezeiraud
added a commit
to gaetandezeiraud/bsdiff-node
that referenced
this pull request
Sep 27, 2019
|
Thanks for the Pull Request. I integrated it into the project bsdiff-nodejs (https://github.com/Exoway/bsdiff-nodejs). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
readandwritereturn a signed int, meaning that they can only readup to 2 billion bytes (2GB) at a time. bsdiff and bspatch were expecting
the entire file to be read (or written, respectively) in a single call
to
readorwrite, which is only possible if they are less than 2GBin size. There are also other times in which a single function call
would be inadequate for IO, for instance in the case where a device is
busy. The fix for this was to place the functions in a loop and continue
as long as at least 1 byte was transferred (in or out). If an error, or 0
return value, comes back from the transfer, break out of the loop and
return the total number of bytes that had been transferred up to that
point.
Updated the .gitignore file to ignore vim swap files, as well as the
autoconf (generated) files and the executables.