Make ChordLine require a chord segment

menees · Feb 11, 2024 · 8ecac73 · 8ecac73
1 parent 036d917
commit 8ecac73
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/Menees.Chords/ChordLine.cs b/src/Menees.Chords/ChordLine.cs
@@ -37,8 +37,10 @@ internal ChordLine(IReadOnlyList<TextSegment> segments, IEnumerable<Entry>? anno
 
 		IReadOnlyList<TextSegment> segments = TryGetSegments(context, false, null, out IReadOnlyList<Entry> annotations);
 
+		// Make sure there's at least one chord segment, so we avoid degenerate
+		// cases like "[]", which is a segment of non-letters but not a chord.
 		ChordLine? result = null;
-		if (segments.Count > 0)
+		if (segments.OfType<ChordSegment>().Any())
 		{
 			result = new(segments);
 			result.AddAnnotations(annotations);

diff --git a/tests/Menees.Chords.Tests/ChordLineTests.cs b/tests/Menees.Chords.Tests/ChordLineTests.cs
@@ -75,6 +75,7 @@ public void TryParseInvalidTest()
 		Test("From N.C.");
 		Test("Am Q7");
 		Test("  [A12]  ");
+		Test("[]");
 
 		static void Test(string text)
 		{