[xds_client_rafactor_step_3] This cannot be real #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
menghanl
force-pushed
the
xds_client_rafactor_step_3
branch
from
0570ea0
to
20eb5bd
Compare
menghanl
force-pushed
the
xds_client_rafactor_step_3
branch
from
20eb5bd
to
01f4c1d
Compare
…dsclient to a separate struct
- new package `controller`, to manage xDS ClientConn and stream
- `transport_helper` and v2/v3 clients are moved to this new package
- v2/v3 are minimized to only handle version specific operations (request building and type assertions)
- Note that they no longer call `UnmarshalLDS` etc, the higher level controller calls them
- v2/v3 are not a part of the controller (opposite of what's before, `transport_helper` is a part of v2/v3 clients)
- some types are moved
- v2 and v3 clients are now under `controller`
- package version (for different v2/v3 type URLs) is now under `xdsresource`
- tests
- delete unused method from fakeserver (because the tests using it are changed)
- renaming in xdsclient tests: `apiclient` -> `controller`
- v2 tests are all moved to controller (v3 tests are __not__ added in this PR)
menghanl
force-pushed
the
xds_client_rafactor_step_3
branch
from
01f4c1d
to
93659b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[xds_client_rafactor_step_3] xdsclient tests passing
[xds_client_rafactor_step_3] new controller with ServerConfig, not top level config