Skip to content

Commit

Permalink
Stop creating vl arrays with fletcher32 filter
Browse files Browse the repository at this point in the history
hdf5 doesn't like that:
h5py/h5py#1948
HDFGroup/hdf5@16349c5

> The 'not suitable for filters' message does seem to have been added
> in 1.12.1 From the code, it looks like it will refuse to apply any
> filters to vlen strings.

This patch is based on the assumption that the hdf5 code is *correct*, and
indeed fletcher32 shouldn't be used in that vlarrays. But if hdf5 is wrong,
then the fix should be their side. It might make sense to apply this to
get the tests passing again, even if ultimately hdf5 is adjusted too.

Fixes PyTables#845.
  • Loading branch information
keszybz authored and mennthor committed Dec 16, 2021
1 parent 19b87e9 commit c842a2f
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions tables/tests/test_vlarray.py
Original file line number Diff line number Diff line change
Expand Up @@ -360,14 +360,9 @@ class ShuffleComprTestCase(BasicTestCase):
shuffle = 1


class Fletcher32TestCase(BasicTestCase):
fletcher32 = 1


class AllFiltersTestCase(BasicTestCase):
compress = 1
shuffle = 1
fletcher32 = 1


class TypesTestCase(common.TempFileMixin, common.PyTablesTestCase):
Expand Down Expand Up @@ -4391,7 +4386,6 @@ def suite():
theSuite.addTest(common.unittest.makeSuite(GetItemRangeTestCase))
theSuite.addTest(common.unittest.makeSuite(SetRangeTestCase))
theSuite.addTest(common.unittest.makeSuite(ShuffleComprTestCase))
theSuite.addTest(common.unittest.makeSuite(Fletcher32TestCase))
theSuite.addTest(common.unittest.makeSuite(AllFiltersTestCase))
theSuite.addTest(common.unittest.makeSuite(CloseCopyTestCase))
theSuite.addTest(common.unittest.makeSuite(OpenCopyTestCase))
Expand Down

0 comments on commit c842a2f

Please sign in to comment.