Python 2 fix: ImportError doesn't have .name

So just parse it manually

menpo/base.py

@@ -338,6 +338,9 @@ class MenpoMissingDependencyError(ImportError):
     """
     def __init__(self, package_name):
         super(MenpoMissingDependencyError, self).__init__()
+        if isinstance(package_name, ImportError):
+            package_name = self._handle_importerror(package_name)
+
         self.message = textwrap.dedent("""
             You need to install the '{pname}' package in order to use this
             functionality. We recommend that you use conda to achieve this -
@@ -350,10 +353,30 @@ def __init__(self, package_name):
             Failing that, try installing use pip:
 
                 pip install {pname}
+                
+            Note that some packages (e.g. scikit-image) may have a different
+            name on pypi/conda than their import (skimage) and thus the above 
+            commands may fail.
         """.format(pname=package_name))
 
         self.missing_name = package_name
 
+    def _handle_importerror(self, error):
+        if hasattr(error, 'name'):
+            return error.name
+        else:
+            try:
+                # Python 2 doesn't have ModuleNotFoundError
+                # (so doesn't have the name attribute)
+                base_name = error.message.split('No module named ')[1]
+                # Furthermore - the default ImportError includes the full path
+                # so we split the name and return just the first part
+                # (presumably the name of the package)
+                return base_name.split('.')[0]
+            except:
+                # Worst case, just stringify the error
+                return str(error)
+
     def __str__(self):
         return self.message
 
@@ -713,7 +736,7 @@ def view_widget(self):
             from menpowidgets import view_widget
         except ImportError as e:
             from menpo.visualize.base import MenpowidgetsMissingError
-            raise MenpowidgetsMissingError(e.name)
+            raise MenpowidgetsMissingError(e)
         else:
             return view_widget(self)
 

menpo/feature/optional/vlfeat.py

@@ -7,7 +7,7 @@
 try:
     from cyvlfeat.sift.dsift import dsift as cyvlfeat_dsift
 except ImportError as e:
-    raise MenpoMissingDependencyError(e.name)
+    raise MenpoMissingDependencyError(e)
 
 
 @winitfeature

menpo/image/base.py

@@ -850,7 +850,7 @@ def view_widget(self, figure_size=(7, 7)):
             view_widget(self, figure_size=figure_size)
         except ImportError as e:
             from menpo.visualize.base import MenpowidgetsMissingError
-            raise MenpowidgetsMissingError(e.name)
+            raise MenpowidgetsMissingError(e)
 
     def _view_landmarks_2d(self, channels=None, group=None,
                            with_labels=None, without_labels=None,

menpo/landmark/base.py

@@ -317,7 +317,7 @@ def _view_widget_2d(self, figure_size=(7, 7)):
             view_widget(self, figure_size=figure_size)
         except ImportError as e:
             from menpo.visualize.base import MenpowidgetsMissingError
-            raise MenpowidgetsMissingError(e.name)
+            raise MenpowidgetsMissingError(e)
 
     def _view_widget_3d(self):
         r"""
@@ -328,7 +328,7 @@ def _view_widget_3d(self):
             view_widget(self)
         except ImportError as e:
             from menpo.visualize.base import MenpowidgetsMissingError
-            raise MenpowidgetsMissingError(e.name)
+            raise MenpowidgetsMissingError(e)
 
     def __str__(self):
         out_string = '{}: n_groups: {}'.format(type(self).__name__,

menpo/model/pca.py

@@ -834,7 +834,7 @@ def plot_eigenvalues_widget(self, figure_size=(10, 6), style='coloured'):
             from menpowidgets import plot_graph
         except ImportError as e:
             from menpo.visualize.base import MenpowidgetsMissingError
-            raise MenpowidgetsMissingError(e.name)
+            raise MenpowidgetsMissingError(e)
         plot_graph(x_axis=range(self.n_active_components),
                    y_axis=[self.eigenvalues], legend_entries=['Eigenvalues'],
                    figure_size=figure_size, style=style)
@@ -983,7 +983,7 @@ def plot_eigenvalues_ratio_widget(self, figure_size=(10, 6),
             from menpowidgets import plot_graph
         except ImportError as e:
             from menpo.visualize.base import MenpowidgetsMissingError
-            raise MenpowidgetsMissingError(e.name)
+            raise MenpowidgetsMissingError(e)
         plot_graph(x_axis=range(self.n_active_components),
                    y_axis=[self.eigenvalues_ratio()],
                    legend_entries=['Eigenvalues ratio'],
@@ -1139,7 +1139,7 @@ def plot_eigenvalues_cumulative_ratio_widget(self, figure_size=(10, 6),
             from menpowidgets import plot_graph
         except ImportError as e:
             from menpo.visualize.base import MenpowidgetsMissingError
-            raise MenpowidgetsMissingError(e.name)
+            raise MenpowidgetsMissingError(e)
         plot_graph(x_axis=range(self.n_active_components),
                    y_axis=[self.eigenvalues_cumulative_ratio()],
                    legend_entries=['Eigenvalues cumulative ratio'],
@@ -1446,7 +1446,7 @@ def view_widget(self, figure_size=(7, 7)):
             view_widget(self, figure_size=figure_size)
         except ImportError as e:
             from menpo.visualize.base import MenpowidgetsMissingError
-            raise MenpowidgetsMissingError(e.name)
+            raise MenpowidgetsMissingError(e)
 
     def __str__(self):
         str_out = 'PCA Model \n'                             \

menpo/shape/graph.py

@@ -2365,7 +2365,7 @@ def _view_3d(self, figure_id=None, new_figure=True, render_lines=True,
             return renderer
         except ImportError as e:
             from menpo.visualize import Menpo3dMissingError
-            raise Menpo3dMissingError(e.name)
+            raise Menpo3dMissingError(e)
 
 
 class PointUndirectedGraph(PointGraph, UndirectedGraph):

menpo/shape/labelled.py

@@ -767,7 +767,7 @@ def _view_3d(self, with_labels=None, without_labels=None, group='group',
                 numbers_colour=numbers_colour, numbers_size=numbers_size)
         except ImportError as e:
             from menpo.visualize import Menpo3dMissingError
-            raise Menpo3dMissingError(e.name)
+            raise Menpo3dMissingError(e)
 
     @viewwrapper
     def view_widget(self, ):
@@ -793,7 +793,7 @@ def _view_widget_2d(self, figure_size=(7, 7)):
             view_widget(self, figure_size=figure_size)
         except ImportError as e:
             from menpo.visualize.base import MenpowidgetsMissingError
-            raise MenpowidgetsMissingError(e.name)
+            raise MenpowidgetsMissingError(e)
 
     def _view_widget_3d(self):
         r"""
@@ -805,7 +805,7 @@ def _view_widget_3d(self):
             view_widget(self)
         except ImportError as e:
             from menpo.visualize.base import MenpowidgetsMissingError
-            raise MenpowidgetsMissingError(e.name)
+            raise MenpowidgetsMissingError(e)
 
     def __str__(self):
         return '{}: n_labels: {}, n_points: {}, n_edges: {}'.format(

menpo/shape/mesh/base.py

@@ -1178,4 +1178,4 @@ def _view_3d(self, figure_id=None, new_figure=True, mesh_type='wireframe',
             return renderer
         except ImportError as e:
             from menpo.visualize import Menpo3dMissingError
-            raise Menpo3dMissingError(e.name)
+            raise Menpo3dMissingError(e)

menpo/shape/mesh/coloured.py

@@ -318,7 +318,7 @@ def _view_3d(self, figure_id=None, new_figure=True, render_texture=True,
                 return renderer
             except ImportError as e:
                 from menpo.visualize import Menpo3dMissingError
-                raise Menpo3dMissingError(e.name)
+                raise Menpo3dMissingError(e)
         else:
             try:
                 from menpo3d.visualize import TriMeshViewer3d
@@ -335,7 +335,7 @@ def _view_3d(self, figure_id=None, new_figure=True, render_texture=True,
                 return renderer
             except ImportError as e:
                 from menpo.visualize import Menpo3dMissingError
-                raise Menpo3dMissingError(e.name)
+                raise Menpo3dMissingError(e)
 
     def _view_2d(self, figure_id=None, new_figure=False, image_view=True,
                  render_lines=True, line_colour='r', line_style='-',

menpo/shape/mesh/textured.py

@@ -370,7 +370,7 @@ def _view_3d(self, figure_id=None, new_figure=True, render_texture=True,
                 return renderer
             except ImportError as e:
                 from menpo.visualize import Menpo3dMissingError
-                raise Menpo3dMissingError(e.name)
+                raise Menpo3dMissingError(e)
         else:
             try:
                 from menpo3d.visualize import TriMeshViewer3d
@@ -387,7 +387,7 @@ def _view_3d(self, figure_id=None, new_figure=True, render_texture=True,
                 return renderer
             except ImportError as e:
                 from menpo.visualize import Menpo3dMissingError
-                raise Menpo3dMissingError(e.name)
+                raise Menpo3dMissingError(e)
 
     def _view_2d(self, figure_id=None, new_figure=False, image_view=True,
                  render_lines=True, line_colour='r', line_style='-',

menpo/shape/pointcloud.py

@@ -986,7 +986,7 @@ def _view_3d(self, figure_id=None, new_figure=True, render_markers=True,
             return renderer
         except ImportError as e:
             from menpo.visualize import Menpo3dMissingError
-            raise Menpo3dMissingError(e.name)
+            raise Menpo3dMissingError(e)
 
     def _view_landmarks_3d(self, group=None, with_labels=None,
                            without_labels=None, figure_id=None,
@@ -1123,7 +1123,7 @@ def _view_widget_2d(self, figure_size=(7, 7)):
             view_widget(self, figure_size=figure_size)
         except ImportError as e:
             from menpo.visualize.base import MenpowidgetsMissingError
-            raise MenpowidgetsMissingError(e.name)
+            raise MenpowidgetsMissingError(e)
 
     def _view_widget_3d(self):
         r"""
@@ -1134,7 +1134,7 @@ def _view_widget_3d(self):
             view_widget(self)
         except ImportError as e:
             from menpo.visualize.base import MenpowidgetsMissingError
-            raise MenpowidgetsMissingError(e.name)
+            raise MenpowidgetsMissingError(e)
 
     def _transform_self_inplace(self, transform):
         self.points = transform(self.points)