Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove label kwarg #614

Closed
patricksnape opened this issue Jul 24, 2015 · 4 comments
Closed

Remove label kwarg #614

patricksnape opened this issue Jul 24, 2015 · 4 comments
Labels
Beginner Friendly enhancement Python

Comments

@patricksnape
Copy link
Contributor

Since we have an API for creating LandmarkGroups from label sets:

new_group = image.landmarks['PTS'].with_labels(['eye'])

I propose we remove the label kwarg to reduce the amount of parameter noise from our methods. Then, we would only have group.
@jabooth
Copy link
Member

jabooth commented Jul 24, 2015

+100. These kwargs are just noise. I've never once used them.

@patricksnape patricksnape mentioned this issue Nov 17, 2015
Merged
@jabooth
Copy link
Member

jabooth commented Nov 23, 2015

@patricksnape with #644 have we got all instances of label? If so shall we close this?

@patricksnape
Copy link
Contributor Author

I believe so - unless anyone else can find any!

@jabooth
Copy link
Member

jabooth commented Nov 24, 2015

Great, in that case we'll get this closed. :)

@jabooth jabooth closed this as completed Nov 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Beginner Friendly enhancement Python
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@patricksnape @jabooth