New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvements to importing multiple assets #375

Merged
merged 3 commits into from May 24, 2014

Conversation

Projects
None yet
2 participants
@jabooth
Member

jabooth commented May 24, 2014

import_images(), import_meshes() and import_landmark_files() have no all grown a verbose flag. Set it to True to get nice dynamic printing of the progress of asset importing (@nontas - proud? ;) ). This PR updates the load_database function to use this newly supported flag, simplifying the database loading code.

We now also raise a ValueError if the glob the user gives provides no assets. Tests are added for this behaviour.

jabooth added a commit that referenced this pull request May 24, 2014

Merge pull request #375 from jabooth/ioprint
improvements to importing multiple assets

@jabooth jabooth merged commit eebfd9a into menpo:master May 24, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@jabooth jabooth deleted the jabooth:ioprint branch May 24, 2014

@jalabort

This comment has been minimized.

Member

jalabort commented May 27, 2014

The verbose flag and the fact the we now raise a ValueError if no assets are found are two simple and great additions to the io module!!! Well done James, I really like this now ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment