Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Performance improvements for Similarity family #397
Simple improvements to
updated the test suite to pass with the new numbers.
To be honest, the test that failed is highly numerically unstable - it's only useful in flagging up the fact that something numerically unstable has changed in the code that the SDM fitter uses, which is exactly what has happened here.
This isn't surprising, as for efficiency reasons this PR moves from doing
which will lead to slight numerical differences that aren't 'good' or 'bad'.