New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename 'feature_type' to 'features throughout Menpo #426

Merged
merged 5 commits into from Sep 5, 2014

Conversation

Projects
None yet
3 participants
@jabooth
Member

jabooth commented Sep 4, 2014

In the past we supported passing strings as features - strings which would be used to decide what function to invoke on image.features. The name feature_type was used for lists of features specifications, which could be strings or actual functions.

Now we have moved to just using functions for features, this name is a little confusing and unwieldy. This PR changes the name from feature_type to features throughout Menpo.

@jabooth jabooth added the in progress label Sep 4, 2014

@nontas

This comment has been minimized.

Member

nontas commented Sep 4, 2014

+1

@patricksnape

This comment has been minimized.

Contributor

patricksnape commented Sep 5, 2014

Happy with this! +1

jabooth added a commit that referenced this pull request Sep 5, 2014

Merge pull request #426 from jabooth/rm_feature_type
rename 'feature_type' to 'features throughout Menpo

@jabooth jabooth merged commit c4c7719 into menpo:master Sep 5, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@jabooth jabooth deleted the jabooth:rm_feature_type branch Sep 5, 2014

@jabooth jabooth referenced this pull request Sep 6, 2014

Merged

tidy classifiers #433

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment