rename 'feature_type' to 'features throughout Menpo #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
Happy with this! +1 |
jabooth
added a commit
that referenced
this pull request
Sep 5, 2014
rename 'feature_type' to 'features throughout Menpo
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past we supported passing strings as features - strings which would be used to decide what function to invoke on
image.features. The namefeature_typewas used for lists of features specifications, which could be strings or actual functions.Now we have moved to just using functions for features, this name is a little confusing and unwieldy. This PR changes the name from
feature_typetofeaturesthroughout Menpo.