Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dgemm calls (replace with np.dot) #517

Merged
merged 3 commits into from
Nov 27, 2014
Merged

Conversation

jabooth
Copy link
Member

@jabooth jabooth commented Nov 24, 2014

We previously used the low-level dgemm routine from scipy in several places. There really isn't any benefit to this, and it makes the code much harder to read. This PR just goes through and replaces all such calls with the approprate np.dot call. It also tidies the the PCAModel constructor in a minor way in preparation for a lazy instantiation pattern in the future (we now grab the tempate at the start and use it for all subsequent initialization rather than manually getting samples[0] each time).

jabooth added a commit that referenced this pull request Nov 27, 2014
remove dgemm calls (replace with np.dot)
@jabooth jabooth merged commit b6f647f into menpo:master Nov 27, 2014
@jabooth jabooth deleted the rm_dgemm branch November 27, 2014 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant