remove dgemm calls (replace with np.dot) #517
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously used the low-level
dgemm
routine from scipy in several places. There really isn't any benefit to this, and it makes the code much harder to read. This PR just goes through and replaces all such calls with the appropratenp.dot
call. It also tidies the thePCAMode
l constructor in a minor way in preparation for a lazy instantiation pattern in the future (we now grab the tempate at the start and use it for all subsequent initialization rather than manually gettingsamples[0]
each time).