New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix BU3DFE connectivity, pretty JSON files #537

Merged
merged 1 commit into from Jan 14, 2015

Conversation

Projects
None yet
2 participants
@jabooth
Member

jabooth commented Jan 14, 2015

Fix a slip up with the connectivity information on the bu3d_fe labeller. Luckily fixing any that we've made incorrectly is quite straightforward:

import menpo

def fix_bu3dfe_landmark(p):
    l = menpo.io.import_landmark_file(p)
    l_fixed = menpo.landmark.labels.bu3dfe_83(l)[1]
    menpo.io.export_landmark_file(l_fixed, p, overwrite=True)


from pathlib import Path

for lm in Path('./dir/of/bad/landmarks').glob('**/*.ljson'):
    fix_bu3dfe_landmark(lm)

I've also changed the landmark LJSON exporter to save out nicely formatted JSON rather than it all scrunched together which is helpful for diffing landmark changes. (landmarkerio server does the same style so diffs are not effected by ordering/style changes now)

@jabooth jabooth added the in progress label Jan 14, 2015

@patricksnape

This comment has been minimized.

Contributor

patricksnape commented Jan 14, 2015

FIne by me

jabooth added a commit that referenced this pull request Jan 14, 2015

Merge pull request #537 from jabooth/bu3d_fix
fix BU3DFE connectivity, pretty JSON files

@jabooth jabooth merged commit 4a03fa9 into menpo:master Jan 14, 2015

2 checks passed

continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci The Travis CI build passed
Details

@jabooth jabooth removed the in progress label Jan 14, 2015

@jabooth jabooth deleted the jabooth:bu3d_fix branch Jan 14, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment