New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPython3 widgets #562

Merged
merged 8 commits into from Mar 6, 2015

Conversation

Projects
None yet
2 participants
@patricksnape
Contributor

patricksnape commented Mar 4, 2015

Fixes widgets for IPython 3.

I didn't really clean the code, I just added and removed the code necessary to get everything working without exceptions.

patricksnape added some commits Mar 4, 2015

Remove *Widget from widgets, remove popup
All widgets no longer have the suffix *Widget and the popup
widget has been removed. Fix this in our widgets.
Change value to default_value
For dropdown, radiobutton and select widgets.
Fix add_class and remove_class
They don't exist so add a compatibility module that replicates
their functionality. This should mostly be replaced by using
the flex box model at some later point.
default_value wasn't the problem
Change back to value
values has been renamed to options
Applies to dropdowns, radios and selections.
Update channel_options
- visualize_images was not rendering greyscale images.
@jalabort

This comment has been minimized.

Member

jalabort commented Mar 5, 2015

I've been using this all day and it's been OK for all my use cases.

I fixed a tiny bug on the menpofit counterpart of this PR. I am happy for both of them to go in.

I believe the code can be cleaned in another PR so that everyone is encourage to move to the new IPython 3.0.

@jalabort

This comment has been minimized.

Member

jalabort commented Mar 5, 2015

+1

patricksnape added a commit that referenced this pull request Mar 6, 2015

@patricksnape patricksnape merged commit 0f9802f into menpo:master Mar 6, 2015

2 checks passed

continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@patricksnape patricksnape deleted the patricksnape:ipython3_widgets branch Mar 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment