Build fixes #643
Merged
Build fixes #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 3.5 Builds
Apparently we had a bug whereby the assert_called_once method was never actually working correct and we should have been checking the call count anyway. This rectifies that.
Remove menpowidgets - we will move to a meta package. Bump Pillow and Matplotlib
Too many dependencies are up in the air on Windows etc
So we can't make that upgrade here. Will have to wait and hopefully it upgrades before we make the release.
|
Finally passing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just fixing the mock issues and upgrading our dependencies. Also, bump to condaci 0.4.8.