Functional IO package #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it simpler to create an importer by removing inheritance from the importer classes. Also, make some of the menpo methods more generic so they can be used by menpo3d. Finally, improve behaviour for importing file types with compound extensions such as .pkl.gz -> Now try all subsequences of extensions rather than just .pkl.gz and .pkl.
Rename functions to function style names and use some of the new logic or looking up compound file types. Fix the tests appropriately.
This was referenced May 19, 2016
Creates a partial and copies the __doc__ and optionally allows setting a name.
You can now register custom image, video, landmark and pickle importers.
dunderscore arguments are mangled in Python2 - so we shouldn't use them.
|
@jabooth Please review me |
| from menpo.visualize import print_progress | ||
|
|
||
| from ..utils import _norm_path, _possible_extensions_from_filepath, \ |
There was a problem hiding this comment.
can we do
from foo import (lots, of,
items)
not a fan of \ + newline
|
@patricksnape really minor comments, but other than those looks really good. +1. |
|
Go home Appveyor you're drunk. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the IO package is much more functional and importers and exporters are just expected to be defined as functions/callables that take either a path (input) or a file handle (output) and do the appropriate job. This makes it much easier for users to leverage the menpo smart globbing etc but actually import whatever they want.
TODO
mio.register_*_importer('.jpg', custom_jpg_importer)