Fix the bug with rasterize landmarks with matplotlib backend. #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -80,7 +80,8 @@ def _rasterize_matplotlib(image, pclouds, render_lines=True, line_style='-', | |||
| # Get the pixels directly from the canvas buffer which is fast | |||
| c_buffer, shape = f.canvas.print_to_buffer() | |||
| # Turn buffer into numpy array and reshape to image | |||
| pixels_buffer = np.array(c_buffer).reshape(shape[::-1] + (-1,)) | |||
| pixels_buffer = np.fromstring(c_buffer, dtype=np.int8).reshape(shape[::-1] + (-1,)) | |||
| pixels_buffer = pixels_buffer.astype(np.uint8) | |||
There was a problem hiding this comment.
No need to cast twice - can just do it once:
# Turn buffer into numpy array and reshape to image
pixels_buffer = np.fromstring(c_buffer,
dtype=np.uint8).reshape(shape[::-1] + (-1,))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The matplotlib backend was causing errors in python 3.
The following code crashed with
ValueError:In my machine it works now (python 2.7 and 3.4).