New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable greyscale video to be exported. #711

Merged
merged 2 commits into from Jun 22, 2016

Conversation

Projects
None yet
3 participants
@grigorisg9gr
Member

grigorisg9gr commented Jun 17, 2016

There was a bug in the pixel format in the ffmpeg writer that only allowed RGB images to be exported.

@patricksnape I tried to insert a related test, but your expertise would be required in case you want such a test.

@jabooth jabooth added the in progress label Jun 17, 2016

@jabooth

This comment has been minimized.

Member

jabooth commented Jun 17, 2016

Looks great, thanks @grigorisg9gr. @patricksnape can decide on whether a test is required, but +1 from me.

Add tests and warnings for video export
Should make the video exporting slightly more robust
@patricksnape

This comment has been minimized.

Contributor

patricksnape commented Jun 22, 2016

Once those tests etc pass then I think this is great, thanks @grigorisg9gr!

@patricksnape patricksnape merged commit 970b4ee into menpo:master Jun 22, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
macOS MenpoBot Jenkins build passed
Details

@patricksnape patricksnape deleted the grigorisg9gr:greyscale_video branch Jun 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment