Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove cython gradient implementation #821

Merged
merged 2 commits into from Jul 12, 2019
Merged

remove cython gradient implementation #821

merged 2 commits into from Jul 12, 2019

Conversation

jabooth
Copy link
Member

@jabooth jabooth commented Aug 1, 2018

removes the cython gradient implementation to just fall back to numpys.

patricksnape
patricksnape approved these changes Jul 12, 2019
View reviewed changes
Copy link
Contributor

@patricksnape patricksnape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did some basic testing - it does seem a bit slower for large number of channels but not so slow that I feel like it isn't worth removing this

@patricksnape patricksnape merged commit df4ef6f into menpo:master Jul 12, 2019
@patricksnape patricksnape deleted the rmcygradient branch July 12, 2019 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patricksnape patricksnape patricksnape approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jabooth @patricksnape