Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Makefile install fails #32

Closed
winston-yallow opened this issue Oct 26, 2019 · 4 comments · Fixed by #33
Closed

Makefile install fails #32

winston-yallow opened this issue Oct 26, 2019 · 4 comments · Fixed by #33

Comments

@winston-yallow
Copy link
Contributor

winston-yallow commented Oct 26, 2019

The make install command still uses the setup.py file which was replaced by the pyproject.toml. I do know that the correct way to install this is with pip3 install -U .

(This is not really important, I just find it weird that the makefile references an obsolete file.)

@winston-yallow
Copy link
Contributor Author

It looks like the command listed in the readme is pip3 -U install . while the correct one probably is pip3 install -U .

I could make a PR changing the Readme and the makefile to the correct command?

@mental32
Copy link
Owner

That Makefile wasn't intended to be used by anyone who wasn't developing, its a sort of makeshift toolchain that I threw together that helps me out.

If you're keen on pr'ing this I'm happy to merge :)

@winston-yallow
Copy link
Contributor Author

Ignore the closed pr that referenced this issue, I made it by accident. The pr #33 is the correct one

@mental32
Copy link
Owner

@winston-yallow No worries, happens to the best of us :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants