Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two small bug fixes #3

Merged
merged 2 commits into from Oct 19, 2019
Merged

Two small bug fixes #3

merged 2 commits into from Oct 19, 2019

Conversation

rabc
Copy link
Contributor

@rabc rabc commented Oct 19, 2019

While testing the (great) idea, I came across two code mistakes:

1- FileSystemExchange init is not marked as public, making it impossible to use outside the LLVS package

2- The two inits inValue has a different first argument but has the same second argument, so when trying to use it with only the second value, the compiler gives the error Ambiguous use of 'init'. Since the two default values are doing the same (creating a UUID), I removed the default value from one of them.

@drewmccormack drewmccormack merged commit de18693 into mentalfaculty:master Oct 19, 2019
@drewmccormack
Copy link
Contributor

Thanks! I found the public FileSystemExchange one in another branch, but not merged yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants