Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify supported operating systems #1

Closed
sanmai-NL opened this issue Dec 19, 2017 · 4 comments
Closed

Clarify supported operating systems #1

sanmai-NL opened this issue Dec 19, 2017 · 4 comments

Comments

@sanmai-NL
Copy link

sanmai-NL commented Dec 19, 2017 •
edited
Loading

The most important issue in evaluating this crate is what operating systems it supports. Right now you mention it works on Windows and Unix. Reading https://doc.rust-lang.org/reference/attributes.html#conditional-compilation, it appears as if this includes macOS, but one can’t be too sure. Could you elaborate a bit in the README and API docs to make this 100 % clear to every potential user?
@sanmai-NL
Copy link
Author

sanmai-NL commented Dec 19, 2017 •
edited
Loading

Extra note. The QStandardPaths docs themselves are clear. Your port is still early, though, compared to the current maturity of QStandardPaths, so that doesn’t reflect the supported OS’es yet. A potential source of confusion.

mentaljam added a commit that referenced this issue Dec 19, 2017
@mentaljam
Clarify supported operating systems
dbb9e43 
- Change `cfg(unix)` to `cfg(target_os = "linux")` in conditional configurations
- Change `Unix` to `Linux` in the crate readme file

Refers #1
@mentaljam
Copy link
Owner

I fully agree with your comment. I have no ability to test it on macOS and don't want to publish any "blind" changes. So currently macOS is leaved unsupported until someone helps with it.

@mentaljam
Copy link
Owner

Please let me know if this issue could be closed now.

@sanmai-NL
Copy link
Author

Yes, thanks!

macOS can be tested via Travis CI. Would be wise to call for help in the README too, there are probably many Rustaceans using macOS. 🙂

mentaljam added a commit that referenced this issue Dec 19, 2017
@mentaljam
Add note about macOS support to the readme
f2f5d3c 
Refers #1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sanmai-NL @mentaljam