Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JVP, HVP [in progress] #167

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

JVP, HVP [in progress] #167

wants to merge 15 commits into from

Conversation

sritchie
Copy link
Member

@sritchie sritchie commented Apr 21, 2024

  • replace perturbed? with something that bubbles up perturbed candidates
  • combine ->partials and extract so we can remove the replace-tag impl in Completed fully, that should never leak out anyway... would be great if that worked.
  • add an extract-primal with support for supplying a tag
  • for vjp, are we correctly handling function outputs? I think we are still only handling structural return values. think through and fix...
  • Can I use extract-tangents with a continuation function to accomplish what I need to? does that get me the completed map that I need? that would be great, because then the same mechanism keeps outputs extensible and I only need to switch on the inputs, just like we do in derivative... I don't think so :(
  • maybe I can do it with a mode argument
  • think through with @littleredcomputer how to manage the versions that return the primal too. can we avoid code duplication?
  • reference in the notes https://hackage.haskell.org/package/ad-4.5.5/docs/Numeric-AD-Mode-Kahn.html
  • fix series output in symbolic-taylor-series test

@sritchie sritchie changed the base branch from main to sritchie/nested April 21, 2024 02:09
Copy link

codecov bot commented Apr 21, 2024

Codecov Report

Attention: Patch coverage is 47.22222% with 38 lines in your changes are missing coverage. Please review.

Project coverage is 87.47%. Comparing base (bd47efd) to head (910a669).

Files Patch % Lines
src/emmy/calculus/derivative.cljc 47.22% 36 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #167      +/-   ##
==========================================
- Coverage   87.69%   87.47%   -0.23%     
==========================================
  Files          99       99              
  Lines       15791    15855      +64     
  Branches      850      851       +1     
==========================================
+ Hits        13848    13869      +21     
- Misses       1093     1135      +42     
- Partials      850      851       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from sritchie/nested to main April 23, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant