Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: additional validation on tradingLimits #257

Merged
merged 2 commits into from Aug 8, 2023
Merged

feat: additional validation on tradingLimits #257

merged 2 commits into from Aug 8, 2023

Conversation

philbow61
Copy link
Contributor

Description

  • checks for Limit0 < Limit1 < LimitG
  • check for Limit0 != 0 and Limit1 != 0 and LimitG != 0 if set

Other changes

  • n/a

Tested

  • new unit test for validate() function

Related issues

Backwards compatibility

  • n/a

Documentation

  • n/a

nvtaveras
nvtaveras approved these changes Aug 7, 2023
View reviewed changes
Copy link
Collaborator

@nvtaveras nvtaveras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚀

@philbow61 philbow61 merged commit a4b01b0 into develop Aug 8, 2023
16 checks passed
@philbow61 philbow61 deleted the feat/additional-validation-on-TradingLimits branch August 8, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowd bowd bowd approved these changes

@nvtaveras nvtaveras nvtaveras approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[L-1] Potential misconfiguration in trading limits
3 participants
@philbow61 @bowd @nvtaveras