-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Criando a primeira versão do modulo de rede GCP da mentoriaiac #2
Conversation
…aveis de subnetworks para receber uma lista de objetos Co-authored-by: Afonso Rodrigues <afonsoaugustoventura@gmail.com> Co-authored-by: Willian dos Santos <will.santos92@gmail.com> Marcio Machado Gabriel Iglesias
Ta ficando MUITO bom. Parabéns ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Está ficando muito bom, só tenho algumas sugestões.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Colocar o type em todas variáveis e condição nas que forem mais pertinentes.
…o os default. Co-authored-by: Marcelo Mansur <marcelomansur@users.noreply.github.com> Co-authored-by: Willian dos Santos <will.santos92@gmail.com> Co-authored-by: Afonso Rodrigues <afonsoaugustoventura@gmail.com> Co-authored-by: Leonardo Oliveira <carlosleoliveira@users.noreply.github.com> Co-authored-by: evandrobeserra <evandrobeserra@users.noreply.github.com> Co-authored-by: r_koga@hotmail.com <r_koga@hotmail.com>
…a de linha no final do arquivo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Precisa melhorar o README apenas.
Nome: "Modulo terraform redes GCP"
Sobre: "Modulo de terraform para provisionar uma estrutura de VPC, subnets e regras de firewall no GCP"
Proposta:
Funcionalidades:
Contribuidores
adrian.w.roque@gmail.com
Anderson Pereira
Evandro Francisco
Felipe Nobrega
G Batista
Lm Oliveira
Luiz Aoqui
Marcio Machado
Marcelo Mansus
Plinio
tanquetav