Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Criando a primeira versão do modulo de rede GCP da mentoriaiac #2

Merged
merged 13 commits into from
Jul 18, 2021

Conversation

Rehzende
Copy link
Member

@Rehzende Rehzende commented Jun 16, 2021


Nome: "Modulo terraform redes GCP"
Sobre: "Modulo de terraform para provisionar uma estrutura de VPC, subnets e regras de firewall no GCP"


Proposta:

Funcionalidades:

  • Criar VPC
  • Criar Subredes
  • Aplicar Regras de firewall por tipo de protocolo e numero da porta

Contribuidores

adrian.w.roque@gmail.com
Anderson Pereira
Evandro Francisco
Felipe Nobrega
G Batista
Lm Oliveira
Luiz Aoqui
Marcio Machado
Marcelo Mansus
Plinio
tanquetav

…aveis de subnetworks para receber uma lista de objetos

Co-authored-by: Afonso Rodrigues <afonsoaugustoventura@gmail.com>
Co-authored-by:
Willian dos Santos <will.santos92@gmail.com>
Marcio Machado
Gabriel Iglesias
@Rehzende Rehzende changed the title Criando a primeira versão do modulo de network GCP da mentoriaiac Criando a primeira versão do modulo de rede GCP da mentoriaiac Jun 18, 2021
variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@gomex
Copy link
Contributor

gomex commented Jun 20, 2021

Ta ficando MUITO bom. Parabéns ;)

Copy link
Contributor

@gomex gomex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Está ficando muito bom, só tenho algumas sugestões.

main.tf Show resolved Hide resolved
Copy link
Contributor

@gomex gomex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Colocar o type em todas variáveis e condição nas que forem mais pertinentes.

…o os default.

Co-authored-by: Marcelo Mansur <marcelomansur@users.noreply.github.com>
Co-authored-by: Willian dos Santos <will.santos92@gmail.com>
Co-authored-by: Afonso Rodrigues <afonsoaugustoventura@gmail.com>
Co-authored-by: Leonardo Oliveira <carlosleoliveira@users.noreply.github.com>
Co-authored-by: evandrobeserra <evandrobeserra@users.noreply.github.com>
Co-authored-by: r_koga@hotmail.com <r_koga@hotmail.com>
@afonsoaugusto afonsoaugusto added this to In progress in Observabilidade Jul 7, 2021
@afonsoaugusto afonsoaugusto moved this from In progress to Review in progress in Observabilidade Jul 7, 2021
output.tf Outdated Show resolved Hide resolved
output.tf Show resolved Hide resolved
Copy link
Contributor

@gomex gomex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Precisa melhorar o README apenas.

@gomex gomex marked this pull request as ready for review July 18, 2021 13:22
@gomex gomex merged commit 466f98a into mentoriaiac:main Jul 18, 2021
Observabilidade automation moved this from Review in progress to Done Jul 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Criar versão v0.0.1 para o modulo de rede do gcp
4 participants