Improve text printing #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using puts to output data retrieved through write is broken. Puts expects a null-terminated string, which is not returned by read. Use write to exactly output the data previously read.
Exit with status 1 if one or more arguments could not be printed.
This reduces the required code in man and additionally, replaces the old broken read/puts implementation. Puts expects a null-terminated string, but write does not return a null-terminted string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the file printing capabilities of the userspace tools.
It fixes the broken
read/putsimplementations incatandman.Additionally, it improves the exit code of cat to return 1 if one or more file could not be printed.