fix str[n]len implementations #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementations do not count the length of empty strings correctly. The following buffer content "\0foo\0" is considered a string with length 4, because the iteration pointer is incremented before it is dereferenced to check for a null char. Replace the broken strlen functions with the implementation of musl libc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementations do not count the length of empty strings correctly.
The following buffer content
"\0foo\0"is considered a string with length 4, because the iteration pointer is incremented before it is dereferenced to check for a null char.Replace the broken
strlenfunctions with the implementation of musl libc.This fixes subtle bugs in the shell's code (e.g.,
cmd_put("\0");).