Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and rework our permission permissions #41

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

fischerling
Copy link
Contributor

  • Added x permissions check for directory traversal.
  • Move the generic open checks to vfs.
  • Make permission checks POSIX conform.
  • Add currently unused exec permission check (will be used by a later pull request)

As defined by POSIX permissions are checked for the first matching class,
user, group or others.
Only the permissions of this first matching class are considered.

For example:
Consider a process running for user and group.
A file with user:group -w- rw- --- is not readable by user, and
thus not readable by the process.
However, it is readable by anyone else in the group.

Additionally, since the permission checks are generic and not exclusive
to the ext2 driver, they are moved to the vfs code.
@Galfurian Galfurian added bug Something isn't working enhancement New feature or request labels Mar 1, 2024
@Galfurian Galfurian merged commit 636f8c6 into mentos-team:develop Mar 1, 2024
17 checks passed
@fischerling fischerling deleted the fix-permissions branch March 14, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants