fix: remove null parameter signatures for tap (#198)

Co-authored-by: Tine Jozelj <tine@tjo.space>
mentos1386 · Mar 2, 2021 · 57132be · 57132be
1 parent 74b7fda
commit 57132be
Show file tree

Hide file tree

Showing 2 changed files with 48 additions and 46 deletions.
diff --git a/lib/raven.interceptor.ts b/lib/raven.interceptor.ts
@@ -41,56 +41,58 @@ export class RavenInterceptor implements NestInterceptor {
 
     // first param would be for events, second is for errors
     return next.handle().pipe(
-      tap(null, (exception) => {
-        if (this.shouldReport(exception)) {
-          Sentry.withScope((scope) => {
-            switch (context.getType<GqlContextType>()) {
-              case 'http':
-                this.addHttpExceptionMetadatas(scope, context.switchToHttp());
-                return this.captureException(
-                  scope,
-                  exception,
-                  localTransformers,
-                );
-              case 'ws':
-                this.addWsExceptionMetadatas(scope, context.switchToWs());
-                return this.captureException(
-                  scope,
-                  exception,
-                  localTransformers,
-                );
-              case 'rpc':
-                this.addRpcExceptionMetadatas(scope, context.switchToRpc());
-                return this.captureException(
-                  scope,
-                  exception,
-                  localTransformers,
-                );
-              case 'graphql':
-                if (!GqlArgumentsHost)
+      tap({
+        error: (exception) => {
+          if (this.shouldReport(exception)) {
+            Sentry.withScope((scope) => {
+              switch (context.getType<GqlContextType>()) {
+                case 'http':
+                  this.addHttpExceptionMetadatas(scope, context.switchToHttp());
                   return this.captureException(
                     scope,
                     exception,
                     localTransformers,
                   );
-                this.addGraphQLExceptionMetadatas(
-                  scope,
-                  GqlArgumentsHost.create(context),
-                );
-                return this.captureException(
-                  scope,
-                  exception,
-                  localTransformers,
-                );
-              default:
-                return this.captureException(
-                  scope,
-                  exception,
-                  localTransformers,
-                );
-            }
-          });
-        }
+                case 'ws':
+                  this.addWsExceptionMetadatas(scope, context.switchToWs());
+                  return this.captureException(
+                    scope,
+                    exception,
+                    localTransformers,
+                  );
+                case 'rpc':
+                  this.addRpcExceptionMetadatas(scope, context.switchToRpc());
+                  return this.captureException(
+                    scope,
+                    exception,
+                    localTransformers,
+                  );
+                case 'graphql':
+                  if (!GqlArgumentsHost)
+                    return this.captureException(
+                      scope,
+                      exception,
+                      localTransformers,
+                    );
+                  this.addGraphQLExceptionMetadatas(
+                    scope,
+                    GqlArgumentsHost.create(context),
+                  );
+                  return this.captureException(
+                    scope,
+                    exception,
+                    localTransformers,
+                  );
+                default:
+                  return this.captureException(
+                    scope,
+                    exception,
+                    localTransformers,
+                  );
+              }
+            });
+          }
+        },
       }),
     );
   }

diff --git a/package.json b/package.json
@@ -98,7 +98,7 @@
   },
   "husky": {
     "hooks": {
-      "*.ts" : [
+      "*.ts": [
         "prettier --write"
       ],
       "commit-msg": "commitlint -E HUSKY_GIT_PARAMS"