Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add execution context in transformer #484

Conversation

lws803
Copy link
Contributor

@lws803 lws803 commented Nov 10, 2022

Adds execution context in transformer so that we can set sentry scope properties based on what's available in the execution context. e.g. setting a query param from request context as a sentry tag

@lws803 lws803 marked this pull request as ready for review November 10, 2022 04:15
package.json Outdated
@@ -1,6 +1,6 @@
{
"name": "nest-raven",
"version": "9.0.0",
"version": "9.0.1",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be 9.1.0 as its a feature and not a bug fix[1]. But we can fix this later.

[1] https://semver.org/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated here :) 14d477e thanks for the quick review!

@mentos1386
Copy link
Owner

mentos1386 commented Nov 10, 2022

Thanks for the contribution @lws803! It looks like a useful thing to have :)

@coveralls
Copy link

coveralls commented Nov 10, 2022

Pull Request Test Coverage Report for Build 3436380349

  • 4 of 5 (80.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 74.775%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/raven.interceptor.ts 4 5 80.0%
Files with Coverage Reduction New Missed Lines %
lib/raven.interceptor.ts 2 78.32%
Totals Coverage Status
Change from base Build 3390912916: 0.0%
Covered Lines: 94
Relevant Lines: 105

💛 - Coveralls

@9renpoto
Copy link
Collaborator

ty your PR :)

@lws803
Copy link
Contributor Author

lws803 commented Nov 11, 2022

Thanks for the approve! ❤️ Though, I think only you guys can merge and publish it 😄

@mentos1386 mentos1386 merged commit 2aeb6b9 into mentos1386:master Nov 11, 2022
@lws803 lws803 deleted the feature/add-execution-context-in-transformer branch November 14, 2022 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants