Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/attachment edit list view #67

Merged
merged 3 commits into from
Oct 7, 2022
Merged

Conversation

menno-ll
Copy link
Collaborator

@menno-ll menno-ll commented Oct 7, 2022

Issue link

Fixes #64

Description

The plugin was not correctly loaded in the attachment list view.
This was because the javascript was loaded after the imageCropPositionerEditFieldsReady event was triggered, not catching the event.
To solve it, on initialize of the javascript, check if the root element already exists, and if so initialize it directly.

How Has This Been Tested?

Visiting both the list view and grid view, and the detail pages of attachments.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@menno-ll menno-ll added this to In progress in To-do list via automation Oct 7, 2022
@menno-ll menno-ll added the bug Something isn't working label Oct 7, 2022
@menno-ll menno-ll merged commit d60afbc into master Oct 7, 2022
To-do list automation moved this from In progress to Done Oct 7, 2022
@menno-ll menno-ll deleted the fix/attachment_edit_list_view branch October 7, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

Plugin only works in media library grid view, not in list view.
1 participant