Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add meow-duplicate and duplicate-and-comment #213

Closed
wants to merge 1 commit into from
Closed

Conversation

eshrh
Copy link
Member

@eshrh eshrh commented Mar 29, 2022

I have written a rudimentary pair of duplication functions that basically save and then yank.

This is basically like crux-duplicate-current-line-or-region from crux, but implemented with meow functions instead. I have found this very useful after I wrote it for myself.

The current duplicate function duplicates a char instead of a line like crux when no region is active. I think this makes sense because selecting a line is natural and common but selecting a char is more awkward (expand right).

I think this is a good candidate for P in suggested keybindings which is currently free [not in commit (yet)]

Any thoughts on this?

@DogLooksGood
Copy link
Collaborator

DogLooksGood commented Mar 30, 2022

Hey, sorry, I'm against this proposal.

There are some reasons:

  1. This is a normal DWIM command, and meow is against this. The command should be separated as for single char, and region.
  2. This command affects the kill-ring, which is unnecessary.
  3. meow-duplicate-and-comment is too complex for its functionality.

And the most imporntant, I don't think meow should cover all the operations. Meow itself is build with operations around a "selection" concept, some features will indeed be missing here, but that's acceptable. I don't think meow has to be a replacement for all editing packages.

@eshrh
Copy link
Member Author

eshrh commented Mar 31, 2022

ok, sounds good. this is fairly trivial to write for a personal config anyway (it's actually straight from my config).

@eshrh eshrh closed this Mar 31, 2022
@eshrh eshrh deleted the duplicate branch March 31, 2022 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants