Merge pull request open-rpc#147 from open-rpc/fix/optional-param-vali…

…dation fix: validate optional params
meowsbits · Jun 14, 2019 · ac71a74 · ac71a74
2 parents 48e37b6 + 4feb647
commit ac71a74
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 30 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/src/method-call-validator/method-call-validator.test.ts b/src/method-call-validator/method-call-validator.test.ts
@@ -51,4 +51,11 @@ describe("MethodCallValidator", () => {
     expect(result[0]).toBeInstanceOf(MethodCallParameterValidationError);
   });
 
+  it("can not error if param is optional", () => {
+    const example = getExampleSchema() as any;
+    const methodCallValidator = new MethodCallValidator(example);
+    const result = methodCallValidator.validate("foo", []);
+    expect(result).toEqual([]);
+  });
+
 });
diff --git a/src/method-call-validator/method-call-validator.ts b/src/method-call-validator/method-call-validator.ts
@@ -67,6 +67,7 @@ export default class MethodCallValidator {
     return _.chain(method.params as ContentDescriptorObject[])
       .map((param: ContentDescriptorObject, index: number): MethodCallParameterValidationError | undefined => {
         if (param.schema === undefined) { return; }
+        if (!params[index] && !param.required) { return; }
 
         const idForMethod = generateMethodParamId(method, param);
         const isValid = this.ajvValidator.validate(idForMethod, params[index]);