Add template for the upcoming migration script #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sledges
force-pushed
the
dhd2modular
branch
4 times, most recently
from
2826991
to
480bfa9
Compare
| # device: should be the CM codename or the AOSP TARGET_PRODUCT | ||
| # vendor: determine the droid-side directory used for ./device/<vendor>/<device> | ||
| # device_pretty: User-visible model name of the device | ||
| # vendor_pretty: User-visible manufacturer name of the device | ||
| # rpm_device: device name used rpm-side (eg in configs) : defaults to device | ||
| # rpm_vendor: vendor name used rpm-side (eg in configs) : defaults to vendor | ||
| # Device capabilities: | ||
| # installable_zip: adds zip updater scripts (default for all SFE devices) | ||
| # enable_kernel_update: ability to flash kernel partition, inspect the usage of this macro |
There was a problem hiding this comment.
Maybe add empty line with # here to categorize it a bit and same above.
…utes to NEMO#801 Signed-off-by: Simonas Leleiva <simonas.leleiva@jollamobile.com>
Signed-off-by: Simonas Leleiva <simonas.leleiva@jollamobile.com>
Signed-off-by: Simonas Leleiva <simonas.leleiva@jollamobile.com>
Signed-off-by: Simonas Leleiva <simonas.leleiva@jollamobile.com> Conflicts: helpers/add_new_device.sh helpers/amibehind.sh
sledges
force-pushed
the
dhd2modular
branch
4 times, most recently
from
6ca3907
to
f714c75
Compare
HADK document will call this script to avoid manually executing a huge amount of commands just to e.g. take in a change in patterns. Also, build bug can now be fixed in this script, instead of releasing a new HADK version.
|
|
||
| source ~/.hadk.env | ||
|
|
||
| ARCH="${ARCH:-armv7hl}" |
There was a problem hiding this comment.
@saukko , how does that sound? We'll remove the default once the new .hadk.env infra is in place
There was a problem hiding this comment.
Sure, eventually this should be removed when it hits the .hadk.env
|
lgtm |
sledges
added a commit
that referenced
this pull request
Apr 28, 2015
Add template for the upcoming migration script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.