Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuration of set_udub ril op #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Pekkari
Copy link

@Pekkari Pekkari commented Oct 31, 2021

In some devices, like the Volla phone, the
operation of set_udub to request whether the
user is busy or not, produces a halt of the modem
dropping any on going call if the operation
happens, like rejecting a new incoming call
while one is active. This patch allows to
set the operation to a regular hangup.

Signed-off-by: José Pekkarinen jose.pekkarinen@foxhound.fi

In some devices, like the Volla phone, the
operation of set_udub to request whether the
user is busy or not, produces a halt of the modem
dropping any on going call if the operation
happens, like rejecting a new incoming call
while one is active. This patch allows to
set the operation to a regular hangup.

Signed-off-by: José Pekkarinen <jose.pekkarinen@foxhound.fi>
# is busy through this function. This produces that, if you cancel an
# awaiting call because of an on going one, both calls will be hang up.
#
#rilRequestOnSetUdub=13
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT the default for RIL_REQUEST_UDUB is 17, please mention that in a way similar to how it's done for other entries.

@@ -27,6 +27,7 @@
#include "ril_vendor.h"
#include "ril_devmon.h"
#include "ril_log.h"
#include "ril-constants.h"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/ril_plugin.c:30:10: fatal error: ril-constants.h: No such file or directory
 #include "ril-constants.h"
          ^~~~~~~~~~~~~~~~~
compilation terminated.

I think you can just drop this line, this header must be included from elsewhere as <ofono/ril-constants.h>

@@ -1806,6 +1811,14 @@ static RilSlot *ril_plugin_parse_config_group(GKeyFile *file,
group, config->cell_info_interval_long_ms);
}

/* rilRequestOnSetUdub */
if (ril_config_get_integer(file, group,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/ril_plugin.c:1815:6: warning: implicit declaration of function 'ril_config_get_integer'; did you mean 'ril_config_get_ints'? [-Wimplicit-function-declaration]
  if (ril_config_get_integer(file, group,
      ^~~~~~~~~~~~~~~~~~~~~~

Should be ofono_conf_get_integer()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants