New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exception on organizations with disabled api access #134
Comments
In my opinion Point 3+2 would be the best solution here |
I'm not sure this is something that needs to get built into the API or the
SDK because it can be handled client side before running operations if you
are expecting to run into 404s as a result of the organization not having
API access enabled.
Separately, we try to avoid building conditionally shown params into any
endpoint.
If I understand your proposal correctly then you would have every endpoint
always return an additional parameter indicating whether or not API was
enabled?
It seems like the amount of effort involved in checking that client side
before performing operations is about the same as writing the error
handling into the client for 404s (current behavior). I wonder how useful
this would be.
Is there some more specific reason why this is a problem that can only be
solved by the API or the SDK?
…On Sun, Dec 27, 2020, 01:10 coreGreenberet ***@***.***> wrote:
In my opinion Point 3+2 would be the best solution here
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#134 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA5EUKTO3AC3IH6TZQEM6ELSW32ZXANCNFSM4VKUNV6A>
.
|
for example you have two organizations A = api enabled now you are making a call to /organizations you get returned A & B next step would probably be -> getOrganizationNetworks on A -> success I'm NOT saying to do it on EVERY endpoint. Just on getOrganizations therefore we could filter out all api enabled/disabled organizations and we don't have to worry about it anymore. On the other hand: Why are api disabled organizations returned by /organizations at all? The main reason, why I think it should be done in the API is because even all the samples are working like I've described above. So all will fail because of that as soon as you have an organization without api access bind to your user. |
This is good feedback and worth considering for handling within the API itself, but we are also open to a community contribution to address this specifically for the SDK. Otherwise, the SDK is technically operating as designed, so I will close this issue. |
Hey,
there is currently an issue with organizations which don't have api access enabled.
If you make requests to such an organization you will receive a 404 Not Found with this message:
which results in an exception on the sdk.
There are 2 problems here:
I can see ways to fix that issue:
I put this issue here up as a discussion base, as I'm unsure, if we should fix this python sdk wise or via meraki endpoint update.
I've also opened a support case on this.
The text was updated successfully, but these errors were encountered: