fix: identation and delete comments #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colbyallenc
reviewed
Sep 19, 2019
| @@ -1,8 +1,7 @@ | |||
| $c-dark-brown: #483700; | |||
| $c-pale: #F9EFDC; | |||
| $primary-font: "AvenirNext", "Avenir Next", sans-serif; | |||
| $c-orange: #F26531; | |||
| // | |||
| $c-orange: #F26531; // | |||
There was a problem hiding this comment.
lets delete the comment lines here! :)
colbyallenc
reviewed
Sep 19, 2019
| @@ -11,8 +10,7 @@ $font-size-sm: 1.125rem; | |||
| $font-size-md: 1.5rem; | |||
| $font-size-lg: 2rem; | |||
| $font-size-xl: 3.625rem; | |||
| $font-size-xxl: 4.5rem; | |||
| // | |||
| $font-size-xxl: 4.5rem; // | |||
colbyallenc
reviewed
Sep 19, 2019
| @@ -79,6 +77,7 @@ $weight-xbold: 900; | |||
| grid-template-columns: repeat(auto-fit, 15rem); | |||
| grid-gap: 1.3rem; | |||
| justify-content: space-around; | |||
|
|
|||
| @media (min-width: 960px) { | |||
There was a problem hiding this comment.
I'm not sure what you breaking point variables look like or if this fits into any that's already created because it's being used in multiple spots. but this doesn't have to be changed here since this is a fix card. Maybe we can keep it in mind for later.
colbyallenc
reviewed
Sep 19, 2019
meranicosme
force-pushed
the
ame--fix-indentation-delete-comments
branch
from
4acb3b4
to
f7ff786
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Description
Fixed all indentation issues across all files.
Deleted all extra comments.
Let me know if you have any questions or comments.
Here is my Invision link for the site design.