Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OOB read in Somfy io-homecontrol #2655

Closed
Mindavi opened this issue Oct 3, 2023 · 1 comment
Closed

OOB read in Somfy io-homecontrol #2655

Mindavi opened this issue Oct 3, 2023 · 1 comment

Comments

@Mindavi
Copy link
Collaborator

Mindavi commented Oct 3, 2023

Probably easy to fix, but I don't have time right now. Found using fuzzing.

Reproducer:

rtl_433 -y "5}fx6x50B005050050500505005050055x" -R189

Causes a segfault in somfy_iohc_decode, I think because the msg_len / data_length is not validated before using as an index.
@Mindavi Mindavi added the bug There is a defect in the code label Oct 3, 2023
@Mindavi Mindavi self-assigned this Oct 3, 2023
@zuckschwerdt zuckschwerdt removed the bug There is a defect in the code label Oct 3, 2023
@zuckschwerdt
Copy link
Collaborator

Thanks. Yes. Minimum msg length check is missing.

kcpants pushed a commit to kcpants/rtl_433 that referenced this issue Oct 15, 2023
@zuckschwerdt @kcpants
Fix Somfy-IOHC length check (closes merbanan#2655)
dbb2090
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zuckschwerdt @Mindavi