Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floating Point Exception when using -a option #48

Closed
jcarduino opened this issue Aug 27, 2014 · 2 comments · Fixed by #62
Closed

Floating Point Exception when using -a option #48

jcarduino opened this issue Aug 27, 2014 · 2 comments · Fixed by #62

Comments

@jcarduino
Copy link
Contributor

Hi,

When checking out some lost waves out here with RTL_433 I stumbled upon a Floating Point Exception.

Digging in it seams to be the line:
min_new = min_new / count_min;

I suspect a device by 0 action, but have not yet be able to confirm this.

update: confirmed... did a print just before the error and count_min -is- 0 at this point:
TEST!!! 3. t: 117 min: 117 (0) max: 118 (247) delta 1

complete loop output:
*** signal_start = 11050637, signal_end = 11308829
signal_len = 258192, pulses = 247
TEST!!! 1. t: 119 min: 117 (54) max: 121 (193) delta 16
Iteration 1. t: 118 min: 117 (54) max: 119 (193) delta 4
TEST!!! 2. t: 118 min: 117 (6) max: 119 (241) delta 4
Iteration 2. t: 117 min: 117 (6) max: 118 (241) delta 1
TEST!!! 3. t: 117 min: 117 (0) max: 118 (247) delta 1
Floating point exception

Any thoughts would be appreciated!

Johan

@baruch baruch mentioned this issue Nov 12, 2014
@baruch
Copy link
Contributor

baruch commented Nov 12, 2014

I had independently hit upon a bug that crashes rtl_433 in a similar way, can you test this branch and see if it fixes your issue as well?

@rct
Copy link
Contributor

rct commented Nov 20, 2014

I've applied your changes and haven't seen an FPE crash since. Thanks. Hopefully merbanan will process your pull request will get processed to add this to the original. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants