Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes most
fprintf()
s to log prints.More work is needed to convert remaining
fprintf()
s and adjust levels and messages. But this should be a good starting point.Generally I found that normal messages should use a module name (Title Case) as source to be user friendly and abnormal messages should use the function name (
__func__
) for easier debugging.Note that this might break scripts that string match on messages.
This builds on #2264 and is preparation for #2254