Add BMW Gen5 TPMS multi-brand support #2834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/devices/tpms_bmw.c
Outdated
| @@ -0,0 +1,150 @@ | |||
| /** @file | |||
| BMW Gen5 TPMS sensor. | |||
| Copyright (C) 2024 Bruno OCTAU (ProfBoc75), @petrjac, Christian W. Zuckschwerdt <christian@zuckschwerdt.org> | |||
There was a problem hiding this comment.
One empty line above needed. The @petrjac needs to be \@petrjac (this needs to be Markdown and also valid Doxygen)
src/devices/tpms_bmw.c
Outdated
| /** | ||
| BMW Gen5 TPMS sensor. | ||
|
|
||
| issue #2821 BMW Gen5 TPMS support open by @petrjac |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
It's related to issue #2821 opened by @petrjac.
This decoder is compatible multi-brand, like HUF, Continental, Schrader/Sensata.
At least, Brand, Sensor ID, Pressure and Temperature byte are properly decoded.
The 3 others byte are related to the tire information programmed by the RDC Tool, like nominal pressure, tire size, but not yet guess as the purpose / behavior change between brand.
Thx.