New Device (WG-PB12V1) #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code started is a modified version of fineoffset.c which is included with rtl_433. Format of packat seems to be similar to LaCrosse, but with no humidity data included.
merbanan
reviewed
Mar 18, 2017
include/data.h
Outdated
| DATA_DOUBLE, /* pointer to a double is stored */ | ||
| DATA_STRING, /* pointer to a string is stored */ | ||
| DATA_DOUBLE, /* pointer to a double is stored */ | ||
| DATA_STRING, /* pointer to a string is stored */ | ||
| DATA_ARRAY, /* pointer to an array of values is stored */ |
merbanan
reviewed
Mar 18, 2017
src/CMakeLists.txt
Outdated
| @@ -44,6 +44,7 @@ add_executable(rtl_433 | |||
| devices/fineoffset_wh1080.c | |||
| devices/generic_remote.c | |||
| devices/generic_temperature_sensor.c | |||
| devices/wg_pb12v1.c | |||
|
Looks good, I will merge after the comments are addressed and there are sample signals in the test repository. |
--- Corrected the indentation of src/CMakelists.txt as per merbanan comment. Also moved the filepath to an alphabetical position. Reverted include/data.h back to original due to stray change, as per merbanan comment. Misc Changes --- During testing found that the MAXPROTOCOLS value in include/data.h had to be increased by one to 76. Found string termination issue in io data output during testing.
|
I have amended the files that you commented on. There are also tests now and I will submit these shortly to the rtl_433_tests repo. Forgive my naivity, but I seem to have introduced a conflict with the change of MAXPROTOCOLS value. This was to ensure the tests were all run. |
|
Please forgive the reminder. I believe all your criteria have been fulfilled. |
panarom
added a commit
to panarom/rtl_433
that referenced
this pull request
Apr 9, 2017
it looks like an erroneous entry was introduced into src/Makefile.am: devices/generic_temperature_sensor_2.c was entered instead of devices/wg_pb12v1.c in commit 31bf6f2 (PR merbanan#494), causing compilation errors (using autoconf installation steps)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code started is a modified version of fineoffset.c which is included with rtl_433. The fineoffset.c device does not correctly decode the information in the packet.
The format of the packet seems to be similar to LaCrosse, but with no humidity data included. http://fredboboss.free.fr/articles/tx29.php
I have added the packet bits to the formatted output ("io"), as I am still decoding some of the unknown bits.
I have begun adding data to the rtl_433_tests repository but do not have a complete collection of data dumps.