Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some uts and some optimization #192

Merged
merged 2 commits into from
Aug 9, 2022

Conversation

nicole-lihui
Copy link
Member

  • add uts
  • optimize http code return is hard code

@nicole-lihui nicole-lihui requested review from a team as code owners August 8, 2022 08:42
@mergify
Copy link

mergify bot commented Aug 8, 2022

Welcome to the Merbridge OpenSource Community!👏

We're delighted to have you onboard 💘

@codecov-commenter
Copy link

Codecov Report

Merging #192 (a72386c) into main (a47ce70) will increase coverage by 20.00%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main     #192       +/-   ##
===========================================
+ Coverage   17.11%   37.12%   +20.00%     
===========================================
  Files           5        5               
  Lines         368      369        +1     
===========================================
+ Hits           63      137       +74     
+ Misses        295      218       -77     
- Partials       10       14        +4     
Flag Coverage Δ
unittests 37.12% <100.00%> (+20.00%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controller/localip/localip.go 31.05% <100.00%> (+7.24%) ⬆️
pkg/cniplugin/plugin.go 36.52% <0.00%> (+26.08%) ⬆️
pkg/cniplugin/kube.go 62.50% <0.00%> (+62.50%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Member

@kebe7jun kebe7jun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mergify mergify bot merged commit 36ee27a into merbridge:main Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants