Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make CNI plugin to work with Kuma #200

Merged
merged 4 commits into from
Aug 15, 2022

Conversation

bartsmykla
Copy link
Contributor

Adjusted CNI configuration to provide argument with the type
of service mesh merbridge is working with and updated code
to make CNI plugin work with Kuma.

  • Adjusted tests for plugin
  • added mac's .DS_store files to .gitignore file

Adjusted CNI configuration to provide argument with the type
of service mesh merbridge is working with and updated code
to make CNI plugin work with Kuma.

+ Adjusted tests for plugin

Signed-off-by: Bart Smykla <bartek@smykla.com>
@bartsmykla bartsmykla requested review from a team as code owners August 11, 2022 09:16
@mergify
Copy link

mergify bot commented Aug 11, 2022

Welcome to the Merbridge OpenSource Community!👏

We're delighted to have you onboard 💘

Copy link
Member

@kebe7jun kebe7jun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost lgtm.

pkg/cniplugin/plugin_config.go Show resolved Hide resolved
Signed-off-by: Bart Smykla <bartek@smykla.com>
@bartsmykla
Copy link
Contributor Author

Working on style-check

Signed-off-by: Bart Smykla <bartek@smykla.com>
Copy link
Member

@dddddai dddddai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

app/cmd/root.go Outdated Show resolved Hide resolved
Signed-off-by: Bart Smykla <bartek@smykla.com>
Copy link
Member

@kebe7jun kebe7jun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm if @dddddai approve.

@mergify mergify bot merged commit ffc42b4 into merbridge:main Aug 15, 2022
@bartsmykla bartsmykla deleted the feat/add-kuma-to-cni-plugin branch August 15, 2022 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants