-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make CNI plugin to work with Kuma #200
feat: make CNI plugin to work with Kuma #200
Conversation
Adjusted CNI configuration to provide argument with the type of service mesh merbridge is working with and updated code to make CNI plugin work with Kuma. + Adjusted tests for plugin Signed-off-by: Bart Smykla <bartek@smykla.com>
Welcome to the Merbridge OpenSource Community!👏 We're delighted to have you onboard 💘 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
almost lgtm.
Signed-off-by: Bart Smykla <bartek@smykla.com>
Working on style-check |
Signed-off-by: Bart Smykla <bartek@smykla.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Signed-off-by: Bart Smykla <bartek@smykla.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm if @dddddai approve.
Adjusted CNI configuration to provide argument with the type
of service mesh merbridge is working with and updated code
to make CNI plugin work with Kuma.
.DS_store
files to.gitignore
file