Fix exclude inbound ports #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome to the Merbridge OpenSource Community!👏 We're delighted to have you onboard 💘 |
dddddai
commented
Aug 16, 2022
| @@ -186,7 +186,7 @@ func parsePodConfigFromAnnotations(annotations map[string]string, pod *podConfig | |||
| } | |||
| } | |||
| pod.statusPort = uint16(statusPort) | |||
| excludeInboundPorts := []uint16{15090, 15006, 15001, 15000, 15020} // todo changeme | |||
There was a problem hiding this comment.
BTW why are we excluding 15000/15006/15001? I don't see this port being excluded by default, please correct me if I'm wrong
kebe7jun
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are missing some auto-excluded inbound ports
See https://github.com/istio/istio/blob/1.14.3/cni/pkg/plugin/redirect.go#L252 and https://github.com/istio/istio/blob/1.14.3/tools/istio-iptables/pkg/capture/run.go#L353